Repository navigation
chore(compose): run RustFS as the object storage of the stacks (#171) - #172
Draft
Olivier SOTIN (T0t1n) wants to merge 2 commits into
Draft
Olivier SOTIN (T0t1n) wants to merge 2 commits into
Olivier SOTIN (T0t1n) wants to merge 2 commits into
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
docker-compose.yml: theminioservice runsrustfs/rustfs:1.0.4instead ofpgsty/silo:latest. Credentials come from the same.envvariables (RUSTFS_ACCESS_KEY: ${MINIO_ROOT_USER},RUSTFS_SECRET_KEY: ${MINIO_ROOT_PASSWORD}). Theserver /datacommand is gone. The healthcheck uses the RustFS readiness route/health/readywith curl, since the image has nomc, with a 60 s start period. Logs go to stdout (RUSTFS_OBS_LOG_DIRECTORYempty).RUSTFS_CHECK_UPDATE=falseturns off the update check RustFS runs at startup (a call toversion.rustfs.com, also attempted on air-gapped installs).docker-compose.dev.yml: same change onopenaev-dev-minio, console kept on 9001, and a named volumerustfsdata(the anonymous/datavolume of a previous Silo container belongs to root, RustFS restarts in a loop on it).README.md: "Object storage" section with the upgrade warning, the dev stack note and the link to the OpenAEV breaking changes page..env.sample: comment updated.Unchanged on purpose: service name
minio, volumes3data,MINIO_ROOT_*variables, port 9000,MINIO_*variables of the OpenAEV service (theOPENAEV_S3_*names only exist from the OpenAEV release of OpenAEV-Platform/openaev#8839, and the stack runslatestimages), collectors and XTM OneS3_*settings.The image tag is pinned to
1.0.4(nolatest): moving data to RustFS is one way, upgrades go through Renovate. No automatic migration: on an existings3datavolume, RustFS stops at startup withPermission denieduntil the volume is backed up and given to uid 10001, as described in the guide.Related issues
latestimages, andgit pullusers get the change at once.How to test this PR
Fresh stack:
Then start the full stack, upload a document in OpenAEV and attach a file in XTM One.
Upgrade from Silo: follow the guide of OpenAEV-Platform/openaev#8839 (
docs/docs/deployment/breaking-changes/MigrationVersion-s3-object-storage-rustfs.md, option 2). Without it,miniostops withPermission deniedon the existing volume and OpenAEV waits for it: nothing is written.Checked locally:
docker compose configon both files; the service definition starts healthy on an empty volume, bucket creation, write and read work, logs come out on stdout (same check as OpenCTI-Platform/docker#621).Checklist
type(scope?): description (#issue)Further comments
The repository has no CI on the compose files: the checks above are manual.
Unrelated, seen on the way: the README still shows a
docker-compose.caldera-executor.ymlcommand, a file removed from the repository; not changed here.